feat(store): add TS store events/ABI, move around exports #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holic
changed the title
holic
commented
Jun 15, 2023
| "event StoreSetField(bytes32 table, bytes32[] key, uint8 schemaIndex, bytes data)", | ||
| "event StoreSetRecord(bytes32 table, bytes32[] key, bytes data)", | ||
| "event StoreEphemeralRecord(bytes32 table, bytes32[] key, bytes data)", | ||
| ] as const; |
There was a problem hiding this comment.
this is the main thing I wanted to import from another package into the browser bundle
dk1a
previously approved these changes
Jun 15, 2023
Comment on lines
23
to
24
|
|
||
| const sortedStoreEventsAbi = storeEventsAbi.slice().sort((a, b) => a.name.localeCompare(b.name)); |
There was a problem hiding this comment.
slice() feels unintuitive as a way to copy an array, [...storeEventsAbi] would be immediately clear, to me at least
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(pulled out of #1033)
Moves codegen into its own build/export, because we can't import from
@latticexyz/storein the browser due to a node-only dependency, and I want to colocate TS definition of store events near the Solidity where they're defined.Once codegen got moved out, it felt a little weird that config was in "library" still, so I moved that out too, and then there wasn't much left, so I just got rid of the notion of "library" (which won't make much sense anyway once #1025 is done and "register" is removed)